Issue 3343020: Add a presubmit check to look for duplicate Valgrind/Heapchecker suppression name...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3343020: Add a presubmit check to look for duplicate Valgrind/Heapchecker suppression name... (Closed)

Created:
10 years, 3 months ago by Lei Zhang

Modified:
9 years, 7 months ago

Reviewers:
stuartmorgan

CC:
chromium-reviews, Timur Iskhodzhanov, Alexander Potapenko, pam+watch_chromium.org, stuartmorgan+watch_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Add a presubmit check to look for duplicate Valgrind/Heapchecker suppression names. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=59405

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+27 lines, -2 lines)			Patch
	M	tools/heapcheck/PRESUBMIT.py	View		2 chunks	+8 lines, -0 lines	0 comments	Download
	M	tools/valgrind/memcheck/PRESUBMIT.py	View		2 chunks	+19 lines, -2 lines	0 comments	Download

Total messages: 2 (0 generated)

Lei Zhang

Doesn't check for duplicates across different suppression files though.

10 years, 3 months ago (2010-09-10 23:39:43 UTC) #1

Nice! LGTM