Issue 3342028: Change the way to detect build slave.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3342028: Change the way to detect build slave. (Closed)

Created:
10 years, 3 months ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
bradnelson, bradn

CC:
chromium-reviews, M-A Ruel

Visibility:
Public.

Change the way to detect build slave. It seems sys.stdout.isatty() is not a good signal on the build slaves. TBR=bradnelson TEST=none BUG=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=59131

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -3 lines)			Patch
	M	gclient.py	View		1 chunk	+4 lines, -3 lines	0 comments	Download

Total messages: 2 (0 generated)

bradn

10 years, 3 months ago (2010-09-10 19:45:06 UTC) #2

Doh, yeah, that's a better way to do it, I thought about suggesting it, but
assumed you had some ulterior motive in the other.

LGTM