Issue 3342016: Turning WebGL and the accelerated compositor on by default (linux and windows...

Issue 3342016: Turning WebGL and the accelerated compositor on by default (linux and windows... (Closed)

Created:
10 years, 3 months ago by Vangelis Kokkevis

Modified:
9 years, 6 months ago

Reviewers:
Ken Russell (switch to Gerrit), Ken Russell (Google), Nico

CC:
chromium-reviews, pam+watch_chromium.org, ben+cc_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Turning WebGL and the accelerated compositor on by default (linux and windows only for the compositor), removing the --enable-webgl flag and adding --disable-webgl and --disable-accelerated-compositing. On the mac --enable-accelerated-compositing still needs to be supplied to enable the compositor. BUG=54469 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=58711

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Patch Set 3 : '' #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+37 lines, -16 lines)			Patch
M	chrome/app/chrome_dll_main.cc	View	1 2	1 chunk	+15 lines, -0 lines	0 comments	Download
M	chrome/browser/dom_ui/ntp_resource_cache.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/renderer_host/browser_render_process_host.cc	View		2 chunks	+2 lines, -3 lines	0 comments	Download
M	chrome/browser/tab_contents/render_view_host_delegate_helper.cc	View		2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/common/chrome_switches.h	View		3 chunks	+2 lines, -1 line	0 comments	Download
M	chrome/common/chrome_switches.cc	View		4 chunks	+9 lines, -3 lines	0 comments	Download
M	chrome/common/sandbox_init_wrapper_mac.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common/sandbox_policy.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/renderer/render_thread.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/renderer/render_view.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/renderer/webgraphicscontext3d_command_buffer_impl.cc	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Ken Russell (switch to Gerrit)

LGTM with the below fixed. http://codereview.chromium.org/3342016/diff/13001/14001 File chrome/app/chrome_dll_main.cc (right): http://codereview.chromium.org/3342016/diff/13001/14001#newcode570 chrome/app/chrome_dll_main.cc:570: // Accelerated compositing is ...

10 years, 3 months ago (2010-09-04 01:29:07 UTC) #2

Nico

10 years, 3 months ago (2010-09-07 20:03:17 UTC) #3

I think we can turn this on for mac too once
http://codereview.chromium.org/3360014/show is in (should be soon).

Expand Messages | Collapse Messages