Issue 3342011: Poll X server for login prompt, in addition to watching file system

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3342011: Poll X server for login prompt, in addition to watching file system (Closed)

Created:
10 years, 3 months ago by Chris Masone

Modified:
9 years, 7 months ago

Reviewers:
Daniel Erat

CC:
chromium-os-reviews_chromium.org, sosa+cc_chromium.org, seano+cc_chromium.org, ericli, petkov+cc_chromium.org

Base URL:
http://git.chromium.org/git/autotest.git

Visibility:
Public.

Description

Poll X server for login prompt, in addition to watching file system Again, I generally can't repro the race conditions that lead to our tests failing to login sometime, but this change adds another layer of checking to help avoid the race that sometimes leads to us attempting to login when the prompt isn't there yet. BUG=chrome-os-partner:711 TEST=BVT Change-Id: Ia18294b70687bf79f6d826771fb16b80d6106bb6

Patch Set 1 #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -2 lines)			Patch
	M	client/bin/site_login.py	View		1 chunk	+6 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages