Issue 3342004: Fixed the default value for 'crash report' on EULA screen....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3342004: Fixed the default value for 'crash report' on EULA screen.... (Closed)

Created:
10 years, 3 months ago by zel

Modified:
9 years, 6 months ago

Reviewers:
Nikita (slow), oshima

CC:
chromium-reviews, nkostylev+cc_chromium.org, davemoore+watch_chromium.org, ben+cc_chromium.org, glotov

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Fixed the default value for 'crash report' on EULA screen. BUG=chromium-os:6364 TEST=make sure EULA screen has 'crash report' checkbox checked by default even after the machine is reimaged. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=58296

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 2

Patch Set 3 : '' #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -21 lines)			Patch
	M	chrome/browser/chromeos/login/eula_view.h	View	1	2 chunks	+0 lines, -3 lines	0 comments	Download
	M	chrome/browser/chromeos/login/eula_view.cc	View	1 2	4 chunks	+10 lines, -18 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

oshima

LGTM but please file a bug so that we don't forget.(see below) http://codereview.chromium.org/3342004/diff/4001/5001 File chrome/browser/chromeos/login/eula_view.cc ...

10 years, 3 months ago (2010-09-02 01:14:20 UTC) #2

zel

http://codereview.chromium.org/3342004/diff/4001/5001 File chrome/browser/chromeos/login/eula_view.cc (right): http://codereview.chromium.org/3342004/diff/4001/5001#newcode192 chrome/browser/chromeos/login/eula_view.cc:192: usage_statistics_checkbox_->SetEnabled(false); On 2010/09/02 01:14:20, oshima wrote: > can you ...

10 years, 3 months ago (2010-09-02 01:41:00 UTC) #3

Expand Messages | Collapse Messages