Issue 3341016: Fix Firefox data import for Mac....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3341016: Fix Firefox data import for Mac.... (Closed)

Created:
10 years, 3 months ago by Miranda Callahan

Modified:
9 years, 7 months ago

Reviewers:
Evan Stade

CC:
chromium-reviews, arv (Not doing code reviews), ben+cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Fix Firefox data import for Mac. r58258 broke Firefox import on the Mac by trying to use a value from g_browser_process, which is not accessible in Mac out-of-process import. Because this value isn't used or needed for the Mac build, don't even create it in the Mac version. BUG=54265 TEST=Firefox import works on Mac again. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=58775

Patch Set 1 : '' #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -2 lines)			Patch
	M	chrome/browser/importer/firefox3_importer.h	View		1 chunk	+4 lines, -1 line	0 comments	Download
	M	chrome/browser/importer/firefox3_importer.cc	View		2 chunks	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages

lgtm, sorry for breakage.

Expand Messages | Collapse Messages