Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 3341009: Re-enable TemplateURLModel.Load on Linux. (Closed)

Created:
10 years, 3 months ago by levin
Modified:
9 years, 6 months ago
CC:
chromium-reviews, ben+cc_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Re-enable TemplateURLModel.Load on Linux. I've run the test over 20k times without any issues. (The test passed nearly instantly in all cases.) I've also run it under valigrind (over 100 times). I've run it with other tests and on its own numerous times with no problems. All of this was done on Linux because that it where the test failed. Also, noteworthy is that this same functionality is run by other tests which the Linux bots have been passing without incident. BUG=53607 TEST=TemplateURLModel.Load Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=88438

Patch Set 1 #

Patch Set 2 : update to ToT. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -8 lines) Patch
M chrome/browser/search_engines/template_url_service_unittest.cc View 1 2 chunks +1 line, -8 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
levin
10 years, 3 months ago (2010-09-02 21:18:09 UTC) #1
sky
Can you add some logging info so that if it does fail again we have ...
10 years, 3 months ago (2010-09-02 22:04:00 UTC) #2
levin
On 2010/09/02 22:04:00, sky wrote: > Can you add some logging info so that if ...
9 years, 6 months ago (2011-06-07 00:31:46 UTC) #3
levin
On 2010/09/02 22:04:00, sky wrote: > Can you add some logging info so that if ...
9 years, 6 months ago (2011-06-07 00:33:21 UTC) #4
sky
LGTM
9 years, 6 months ago (2011-06-07 00:33:55 UTC) #5
commit-bot: I haz the power
Can't apply patch for file chrome/browser/search_engines/template_url_model_unittest.cc. While running patch -p1 --forward --force; patching file chrome/browser/search_engines/template_url_model_unittest.cc ...
9 years, 6 months ago (2011-06-07 18:22:07 UTC) #6
commit-bot: I haz the power
9 years, 6 months ago (2011-06-08 23:26:46 UTC) #7
Change committed as 88438

Powered by Google App Engine
This is Rietveld 408576698