Issue 3341004: Bandaid around a weird crasher were we end up with a NULL infobar.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3341004: Bandaid around a weird crasher were we end up with a NULL infobar. (Closed)

Created:
10 years, 3 months ago by Jay Civelli

Modified:
9 years, 7 months ago

Reviewers:
sky

CC:
chromium-reviews, ben+cc_chromium.org

Base URL:
http://src.chromium.org/git/chromium.git

Visibility:
Public.

Description

Bandaid around a weird crasher were we end up with a NULL infobar. BUG=53979 TEST=None (wish I knew how to repro...) Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=58257

Patch Set 2 : Style fix. #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -4 lines)			Patch
	M	chrome/browser/translate/translate_manager.cc	View	1	1 chunk	+10 lines, -4 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

sky

http://codereview.chromium.org/3341004/diff/1/2 File chrome/browser/translate/translate_manager.cc (right): http://codereview.chromium.org/3341004/diff/1/2#newcode619 chrome/browser/translate/translate_manager.cc:619: if (translate_delegate) Can we just return translate_delegate? http://codereview.chromium.org/3341004/diff/1/2#newcode620 chrome/browser/translate/translate_manager.cc:620: ...

10 years, 3 months ago (2010-09-01 21:39:37 UTC) #2

Jay Civelli

10 years, 3 months ago (2010-09-01 22:15:39 UTC) #3

LGTM

Expand Messages | Collapse Messages

Issue 3341004: Bandaid around a weird crasher were we end up with a NULL infobar. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Style fix. #

Messages