Add VisitCallNew to fast compiler.

Add VisitCallNew to fast compiler.

Committed: http://code.google.com/p/v8/source/detail?r=3148

[William Hesse, 2009-10-27 13:30:28]

http://codereview.chromium.org/334041/diff/1/6
File src/arm/fast-codegen-arm.cc (right):

http://codereview.chromium.org/334041/diff/1/6#newcode590
Line 590: // Replace function on TOS with result in eax, or pop it.
Will change eax to r0.

[Kevin Millikin (Chromium), 2009-10-27 13:53:57]

LGTM, with a couple small fixups.  The IA32 comments apply to the other
platforms as well.

http://codereview.chromium.org/334041/diff/1/6
File src/arm/fast-codegen-arm.cc (right):

http://codereview.chromium.org/334041/diff/1/6#newcode595
Line 595: __ add(sp, sp, Operand(kPointerSize));
You should write __ pop() on ARM.

http://codereview.chromium.org/334041/diff/1/2
File src/ia32/fast-codegen-ia32.cc (right):

http://codereview.chromium.org/334041/diff/1/2#newcode551
Line 551: void FastCodeGenerator::VisitCallNew(CallNew* node) {
We've been trying to keep these sorted in AST node order (as in ast.h), so
CallNew goes after Call and before CallRuntime.

http://codereview.chromium.org/334041/diff/1/2#newcode586
Line 586: if (node->location().is_temporary()) {
Write this as a switch over (node->location().type()) for now, so we'll get
compilation failures rather than ASSERT failures if we forget a case.

[William Hesse, 2009-10-27 14:45:38]

http://codereview.chromium.org/334041/diff/1/6
File src/arm/fast-codegen-arm.cc (right):

http://codereview.chromium.org/334041/diff/1/6#newcode590
Line 590: // Replace function on TOS with result in eax, or pop it.
On 2009/10/27 13:30:28, William Hesse wrote:
> Will change eax to r0.

Done.

http://codereview.chromium.org/334041/diff/1/6#newcode595
Line 595: __ add(sp, sp, Operand(kPointerSize));
On 2009/10/27 13:53:57, Kevin Millikin wrote:
> You should write __ pop() on ARM.

Done.

http://codereview.chromium.org/334041/diff/1/2
File src/ia32/fast-codegen-ia32.cc (right):

http://codereview.chromium.org/334041/diff/1/2#newcode551
Line 551: void FastCodeGenerator::VisitCallNew(CallNew* node) {
On 2009/10/27 13:53:57, Kevin Millikin wrote:
> We've been trying to keep these sorted in AST node order (as in ast.h), so
> CallNew goes after Call and before CallRuntime.

Done.

http://codereview.chromium.org/334041/diff/1/2#newcode586
Line 586: if (node->location().is_temporary()) {
On 2009/10/27 13:53:57, Kevin Millikin wrote:
> Write this as a switch over (node->location().type()) for now, so we'll get
> compilation failures rather than ASSERT failures if we forget a case.

Done.