Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issue 334030: Remove dupes when generating the list of tests to show in the... (Closed)

Created:
11 years, 1 month ago by ojan
Modified:
9 years, 7 months ago
Reviewers:
Julie Parent
CC:
chromium-reviews_googlegroups.com, darin (slow to review), pam+watch_chromium.org
Visibility:
Public.

Description

Remove dupes when generating the list of tests to show in the layout test dashboard. Also, if a path does not match any failing tests, then assume it's a full path so we can still show it's expectations. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30104

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -3 lines) Patch
M webkit/tools/layout_tests/flakiness_dashboard.html View 2 chunks +16 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
ojan
11 years, 1 month ago (2009-10-26 21:39:10 UTC) #1
Julie Parent
11 years, 1 month ago (2009-10-26 21:48:15 UTC) #2
LGTM

Add a comment in the code about why you use the extra object (to de-dupe).

Powered by Google App Engine
This is Rietveld 408576698