Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Issue 334020: Attempts to get the chrome_frame_tests going again on the chrome frame builde... (Closed)

Created:
11 years, 2 months ago by ananta
Modified:
9 years, 6 months ago
Reviewers:
amit
CC:
chromium-reviews_googlegroups.com, amit
Visibility:
Public.

Description

Attempts to get the chrome_frame_tests going again on the chrome frame builder. Fixes as below:- 1. Removed a DCHECK from ChromeFrameAutomationClient::CleanupRequests which checks if the request was actually deleted. This DCHECK is not correct anymore as the request is stopped asynchronously. 2. We now stop the worker thread in WM_DESTROY as the activex window needs to be valid for Urlmon requests to be released correctly. In some cases IE reuses the ActiveX instance. So we need to create the worker thread on demand. TBR=amit Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30007

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -14 lines) Patch
M chrome_frame/chrome_frame_activex_base.h View 5 chunks +21 lines, -13 lines 0 comments Download
M chrome_frame/chrome_frame_automation.cc View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 1 (0 generated)
ananta
11 years, 2 months ago (2009-10-24 16:23:45 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698