Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(997)

Issue 334018: Switch optimization cflag to late-resolve the debug_optimize and release_optimize vars. (Closed)

Created:
11 years, 2 months ago by awong
Modified:
9 years, 7 months ago
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

Switch optimization cflag to late-resolve the debug_optimize and release_optimize vars. This will allow lower-level targets to change their desired optimization level. In particular, the ffmpeg build requires this because it has problems compiling with -O0. BUG=22307 TEST=none

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M build/common.gypi View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
awong
Here's the late resolution change. Running through try servers, and going to do a test ...
11 years, 2 months ago (2009-10-24 02:16:50 UTC) #1
Mark Mentovai
http://www.lge.com/us/
11 years, 2 months ago (2009-10-24 03:56:19 UTC) #2
Timur Iskhodzhanov
11 years, 1 month ago (2009-10-27 06:35:55 UTC) #3
This change might have affected Valgrind/ThreadSanitizer bots as they support
"-O1 -g -fno-inline -fno-omit-frame-pointer -fno-builtin" as the maximum
optimization level.
I'll investigate whether this is the case and file a bug issue if appropriate.

Powered by Google App Engine
This is Rietveld 408576698