Issue 334017: Use FilePath in UserDataDirDialog to remove the use of FilePath::FromWString...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 334017: Use FilePath in UserDataDirDialog to remove the use of FilePath::FromWString... (Closed)

Created:
11 years, 2 months ago by tfarina (gmail-do not use)

Modified:
9 years, 7 months ago

Reviewers:
Avi (use Gerrit)

CC:
chromium-reviews_googlegroups.com, ben+cc_chromium.org

Base URL:
http://src.chromium.org/svn/trunk/src/

Visibility:
Public.

Use FilePath in UserDataDirDialog to remove the use of FilePath::FromWStringHack. BUG=None TEST=None Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30584

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+12 lines, -12 lines)			Patch
M	chrome/browser/browser_main.cc	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/browser/views/user_data_dir_dialog.h	View	4 chunks	+6 lines, -5 lines	0 comments	Download
M	chrome/browser/views/user_data_dir_dialog.cc	View	2 chunks	+5 lines, -5 lines	0 comments	Download

Total messages: 6 (0 generated)

tfarina (gmail-do not use)

On 2009/10/26 16:06:45, Avi wrote: > LG Could land to me?

11 years, 1 month ago (2009-10-27 22:22:47 UTC) #3

tfarina (gmail-do not use)

On 2009/10/27 22:22:47, tfarina wrote: > On 2009/10/26 16:06:45, Avi wrote: > > LG > ...

11 years, 1 month ago (2009-10-27 22:23:15 UTC) #4

tfarina (gmail-do not use)

11 years, 1 month ago (2009-10-30 18:14:48 UTC) #6

On 2009/10/30 16:16:35, Avi wrote:
> Committed r30584.

Thanks Avi.