Fix status reporting and auto-seq logic.

Fix status reporting and auto-seq logic.

BUG=chrome-os-partner:921
Change-Id: I547ef320d942504b839125a9aa4e9aeff8f21d99

TEST=

[Hung-Te, 2010-09-07 03:57:14]

LGTM except some minor suggestions

http://codereview.chromium.org/3340013/diff/1/2
File client/bin/factory.py (right):

http://codereview.chromium.org/3340013/diff/1/2#newcode264
client/bin/factory.py:264: if parent_as is not None:
will "is parent_as:" work?
(not sure if parent_as would contain some special implicitly False value)

http://codereview.chromium.org/3340013/diff/1/2#newcode271
client/bin/factory.py:271: subtest_status_set = set(map(lookup_fn,
test.subtest_list))
any special reason to not use list comprehension here?

[Tammo Spalink, 2010-09-07 07:02:55]

http://codereview.chromium.org/3340013/diff/1/2
File client/bin/factory.py (right):

http://codereview.chromium.org/3340013/diff/1/2#newcode252
client/bin/factory.py:252: parent_as = self.test_db.get_subtest_parent(test)
parent_as is set here, and is null if there is no parent

http://codereview.chromium.org/3340013/diff/1/2#newcode264
client/bin/factory.py:264: if parent_as is not None:
see above

On 2010/09/07 03:57:14, Hung-Te wrote:
> will "is parent_as:" work?
> (not sure if parent_as would contain some special implicitly False value)

http://codereview.chromium.org/3340013/diff/1/2#newcode271
client/bin/factory.py:271: subtest_status_set = set(map(lookup_fn,
test.subtest_list))
that would, in fact, be much nicer -- will fix

On 2010/09/07 03:57:14, Hung-Te wrote:
> any special reason to not use list comprehension here?

[Hung-Te, 2010-09-07 08:04:04]

LGTM with a comment to unused arg

http://codereview.chromium.org/3340013/diff/6001/7001
File client/bin/factory.py (right):

http://codereview.chromium.org/3340013/diff/6001/7001#newcode220
client/bin/factory.py:220: def filter(self, target_status, only_top_level=True):
this is not used (yet) - maybe in the future?

[Tammo Spalink, 2010-09-07 08:15:25]

http://codereview.chromium.org/3340013/diff/6001/7001
File client/bin/factory.py (right):

http://codereview.chromium.org/3340013/diff/6001/7001#newcode220
client/bin/factory.py:220: def filter(self, target_status, only_top_level=True):
Well, you (Verify) are the only user, and it looks like you would be best served
by filtering all tests for now.  Can always add this later, so removed for now.

On 2010/09/07 08:04:04, Hung-Te wrote:
> this is not used (yet) - maybe in the future?