Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(151)

Issue 3340010: Fix cycle cracking once and for all. (Closed)

Created:
10 years, 3 months ago by davidjames
Modified:
9 years, 4 months ago
Reviewers:
Nick Sanders
CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa
Visibility:
Public.

Description

Fix cycle cracking once and for all. While testing parallel_emerge, I found more cases where it would fail to crack cycles. The issue is that parallel_emerge simply cracks the first cycle it finds that involves an edge, rather than all cycles that involve an edge. Finding all cycles that involve an edge without looping forever is a rather difficult problem, so I've updated the algorithm to simply keep searching until it runs out of cycles. Testing this, I haven't found any cases where the performance of the cycle cracking is a problem. I updated the algorithm to log its performance stats so we can track this. TEST=emerge -ep portage BUG=none Change-Id: I1cb95ffe9d977b9f8d38626d2d6cdbb766c14669

Patch Set 1 #

Patch Set 2 : Confirm no changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -14 lines) Patch
M parallel_emerge View 3 chunks +15 lines, -14 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Nick Sanders
10 years, 3 months ago (2010-09-07 23:45:04 UTC) #1
lgtm

Powered by Google App Engine
This is Rietveld 408576698