Issue 3338019: [autotest] Grab more chrome logs, not just the last one, to hedge against crashes

Issue 3338019: [autotest] Grab more chrome logs, not just the last one, to hedge against crashes (Closed)

Created:
10 years, 3 months ago by Chris Masone

Modified:
9 years, 7 months ago

Reviewers:
rginda, seano

CC:
chromium-os-reviews_chromium.org, sosa+cc_chromium.org, seano+cc_chromium.org, ericli, petkov+cc_chromium.org

Base URL:
http://git.chromium.org/git/autotest.git

Visibility:
Public.

Description

[autotest] Grab more chrome logs, not just the last one, to hedge against crashes There are still some "Timed out waiting for login" failures on the BVT, always in desktopui_ChromeFirstRender for some reason. These failures also seem to have empty chrome logs for some frustrating reason. This change clears out old chrome logs when we restart the browser before login and then just grabs ALL the prelogin chrome logs at the end of the test. BUG=None TEST=BVT Change-Id: Icc0122d8dd7e5abd505e4affdc3e50bfaaeb4575

Patch Set 1 #

Patch Set 2 : fix linewrap #

Total comments: 4

Patch Set 3 : fixes per rginda, seano #

Total comments: 1

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+25 lines, -5 lines)			Patch
	M	client/bin/site_login.py	View	1 2	1 chunk	+18 lines, -3 lines	1 comment	Download
	M	client/bin/site_ui_test.py	View	1 2	1 chunk	+7 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

seano

LGTM http://codereview.chromium.org/3338019/diff/3001/4002 File client/bin/site_ui_test.py (right): http://codereview.chromium.org/3338019/diff/3001/4002#newcode5 client/bin/site_ui_test.py:5: import dbus, glob, logging, os, shutil, socket, sys, ...

10 years, 3 months ago (2010-09-09 19:56:03 UTC) #3

rginda

http://codereview.chromium.org/3338019/diff/3001/4001 File client/bin/site_login.py (right): http://codereview.chromium.org/3338019/diff/3001/4001#newcode308 client/bin/site_login.py:308: for file in os.listdir(logpath) \ This looks a bit ...

10 years, 3 months ago (2010-09-09 20:01:51 UTC) #4

rginda

lgtm after tiny fix http://codereview.chromium.org/3338019/diff/9001/10001 File client/bin/site_login.py (right): http://codereview.chromium.org/3338019/diff/9001/10001#newcode311 client/bin/site_login.py:311: os.unlink(os.path.join(logpath, file)) fullpath, no?

10 years, 3 months ago (2010-09-09 21:01:31 UTC) #5

Chris Masone

10 years, 3 months ago (2010-09-09 21:08:59 UTC) #6

http://codereview.chromium.org/3338019/diff/3001/4001
File client/bin/site_login.py (right):

http://codereview.chromium.org/3338019/diff/3001/4001#newcode308
client/bin/site_login.py:308: for file in os.listdir(logpath) \
On 2010/09/09 20:01:51, rginda wrote:
> This looks a bit awkward.  Why not put the if inside the for?

Done.

http://codereview.chromium.org/3338019/diff/3001/4002
File client/bin/site_ui_test.py (right):

http://codereview.chromium.org/3338019/diff/3001/4002#newcode5
client/bin/site_ui_test.py:5: import dbus, glob, logging, os, shutil, socket,
sys, time
On 2010/09/09 19:56:03, seano wrote:
> You don't use this module in the patch I'm seeing...

Done.

Expand Messages | Collapse Messages