Issue 3338007: Handle argument conversion in StringAddStub.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3338007: Handle argument conversion in StringAddStub. (Closed)

Created:
10 years, 3 months ago by Vitaly Repeshko

Modified:
9 years, 7 months ago

Reviewers:
Søren Thygesen Gjesse

CC:
v8-dev

Visibility:
Public.

Description

Handle argument conversion in StringAddStub. In case one of the arguments is known to be a string we emit a few fast conversion attempts for the other. This allows using the StringAddStub instead of STRING_ADD_{LEFT,RIGHT} builtins. Committed: http://code.google.com/p/v8/source/detail?r=5405

Patch Set 1 #

Patch Set 2 : Test added #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+137 lines, -58 lines)			Patch
M	src/ia32/code-stubs-ia32.h	View		1 chunk	+18 lines, -7 lines	0 comments	Download
M	src/ia32/code-stubs-ia32.cc	View	1	8 chunks	+91 lines, -40 lines	0 comments	Download
M	src/ia32/codegen-ia32.cc	View		1 chunk	+4 lines, -4 lines	0 comments	Download
M	test/mjsunit/binary-op-newspace.js	View		1 chunk	+24 lines, -7 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Søren Thygesen Gjesse

10 years, 3 months ago (2010-09-03 11:47:14 UTC) #2

LGTM!

Please open a x64/ARM porting bug if not porting immediately.

Expand Messages | Collapse Messages