Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 3337020: image_to_usb: Add an option to install to the USB stick. (Closed)

Created:
10 years, 3 months ago by Kenneth Waters
Modified:
9 years, 7 months ago
Reviewers:
Olof Johansson
CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa
Visibility:
Public.

Description

image_to_usb: Add an option to install to the USB stick. - This is needed for devices which use a USB stick or MMC card as their primary storage. BUG=1150 TEST=Installed an image to a MMC card, and copied an image to a MMC card.

Patch Set 1 #

Patch Set 2 : Throw error for board undefined case. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+44 lines, -5 lines) Patch
M image_to_usb.sh View 1 5 chunks +44 lines, -5 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Kenneth Waters
10 years, 3 months ago (2010-09-09 18:47:40 UTC) #1
Kenneth Waters
Fix reviewers email address.
10 years, 3 months ago (2010-09-09 19:52:27 UTC) #2
Olof Johansson
I think you need to add a check to make sure --board is specified when ...
10 years, 3 months ago (2010-09-09 20:42:45 UTC) #3
Kenneth Waters
Sorry I never use the --from option. PTAL.
10 years, 3 months ago (2010-09-09 20:58:43 UTC) #4
Olof Johansson
10 years, 3 months ago (2010-09-09 21:41:01 UTC) #5
On 2010/09/09 20:58:43, Kenneth Waters wrote:
> Sorry I never use the --from option.  PTAL.

It's what build_image shows at the end of a run, and I normally cut and paste
that.

LGTM.

Powered by Google App Engine
This is Rietveld 408576698