Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(728)

Unified Diff: presubmit_support.py

Issue 3337018: Add pylint to presubmit checks (Closed)
Patch Set: execute the drover config file in the current closure Created 10 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « drover.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: presubmit_support.py
diff --git a/presubmit_support.py b/presubmit_support.py
index f0676c65fa183f82d5493df36d718983bb099fd8..c03c3eabf35d736b2702e8afc3f8f3a0d340bd81 100755
--- a/presubmit_support.py
+++ b/presubmit_support.py
@@ -588,18 +588,18 @@ class Change(object):
# From the description text, build up a dictionary of key/value pairs
# plus the description minus all key/value or "tag" lines.
- self._description_without_tags = []
+ description_without_tags = []
self.tags = {}
for line in self._full_description.splitlines():
m = self._TAG_LINE_RE.match(line)
if m:
self.tags[m.group('key')] = m.group('value')
else:
- self._description_without_tags.append(line)
+ description_without_tags.append(line)
# Change back to text and remove whitespace at end.
- self._description_without_tags = '\n'.join(self._description_without_tags)
- self._description_without_tags = self._description_without_tags.rstrip()
+ self._description_without_tags = (
+ '\n'.join(description_without_tags).rstrip())
self._affected_files = [
self._AFFECTED_FILES(info[1], info[0].strip(), self._local_root)
« no previous file with comments | « drover.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698