Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3282)

Unified Diff: drover.py

Issue 3337018: Add pylint to presubmit checks (Closed)
Patch Set: execute the drover config file in the current closure Created 10 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome-update.py ('k') | presubmit_support.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: drover.py
diff --git a/drover.py b/drover.py
index 77922cd705790ca75d2bad7bf129ad629c63c795..9329fda2b6611781c79fafe97813d25e6d80181b 100755
--- a/drover.py
+++ b/drover.py
@@ -402,11 +402,9 @@ def drover(options, args):
# Override the default properties if there is a drover.properties file.
global file_pattern_
if os.path.exists("drover.properties"):
- f = open("drover.properties")
- exec(f)
- f.close()
- if FILE_PATTERN:
- file_pattern_ = FILE_PATTERN
+ FILE_PATTERN = file_pattern_
+ execfile("drover.properties")
+ file_pattern_ = FILE_PATTERN
if options.revert and options.branch:
url = BRANCH_URL.replace("$branch", options.branch)
« no previous file with comments | « chrome-update.py ('k') | presubmit_support.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698