Add pylint to presubmit checks

Add pylint to presubmit checks.

This tool has been quite useful noticing errors in the past and I'd have avoided a breakage in r58936 if I had run it.

Had to fix a few scripts first.

BUG=none
TEST=new test

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=59107

[M-A Ruel, 2010-09-09 16:33:03]

Anthony, can you verify the change I've done in drover.py fits what your
expected usage?

Brad can review the rest.

[bradn, 2010-09-09 17:39:33]

LGTM

[laforge, 2010-09-09 18:58:13]

I don't think that will work for Drover.  The drover.properties file
contains about 5-6 vars that overrides the default constants with the same
name.  I don't really want to have to add a new entry to check local_vars
and set the var (we'd need to do it that way to maintain
backward compatibility).


On Thu, Sep 9, 2010 at 10:39 AM, <bradnelson@google.com> wrote:

> LGTM
>
>
> http://codereview.chromium.org/3337018/show
>

[M-A Ruel, 2010-09-09 19:14:52]

On 2010/09/09 18:58:13, laforge wrote:
> I don't think that will work for Drover.  The drover.properties file
> contains about 5-6 vars that overrides the default constants with the same
> name.  I don't really want to have to add a new entry to check local_vars
> and set the var (we'd need to do it that way to maintain
> backward compatibility).

Is the new code better?

[laforge, 2010-09-10 00:56:34]

LGTM, that looks safer.