chrome/browser/views/bookmark_bubble_view.cc - Issue 3337006: Revert 58388 - Revert 58215 - Revert 58186 - Move the keyboard files from bas...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/views/bookmark_bubble_view.cc

Issue 3337006: Revert 58388 - Revert 58215 - Revert 58186 - Move the keyboard files from bas... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: Created 10 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/views/bookmark_bar_view_test.cc ('k') | chrome/browser/views/browser_keyboard_accessibility_test_win.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/views/bookmark_bubble_view.cc

===================================================================

--- chrome/browser/views/bookmark_bubble_view.cc (revision 58389)

+++ chrome/browser/views/bookmark_bubble_view.cc (working copy)

@@ -4,9 +4,9 @@

#include "chrome/browser/views/bookmark_bubble_view.h"

-#include "app/keyboard_codes.h"

#include "app/l10n_util.h"

#include "app/resource_bundle.h"

+#include "base/keyboard_codes.h"

#include "base/string16.h"

#include "base/string_util.h"

#include "chrome/app/chrome_dll_resource.h"

@@ -129,7 +129,7 @@

void BookmarkBubbleView::BubbleShown() {

DCHECK(GetWidget());

GetFocusManager()->RegisterAccelerator(

- views::Accelerator(app::VKEY_RETURN, false, false, false), this);

+ views::Accelerator(base::VKEY_RETURN, false, false, false), this);

title_tf_->RequestFocus();

title_tf_->SelectAll();

@@ -137,7 +137,7 @@

bool BookmarkBubbleView::AcceleratorPressed(

const views::Accelerator& accelerator) {

- if (accelerator.GetKeyCode() != app::VKEY_RETURN)

+ if (accelerator.GetKeyCode() != base::VKEY_RETURN)

return false;

if (edit_button_->HasFocus())

« no previous file with comments | « chrome/browser/views/bookmark_bar_view_test.cc ('k') | chrome/browser/views/browser_keyboard_accessibility_test_win.cc » ('j') | no next file with comments »