Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(379)

Unified Diff: chrome/browser/views/accessible_toolbar_view.cc

Issue 3337006: Revert 58388 - Revert 58215 - Revert 58186 - Move the keyboard files from bas... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/views/accelerator_table_gtk.cc ('k') | chrome/browser/views/bookmark_bar_view_test.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/views/accessible_toolbar_view.cc
===================================================================
--- chrome/browser/views/accessible_toolbar_view.cc (revision 58389)
+++ chrome/browser/views/accessible_toolbar_view.cc (working copy)
@@ -18,11 +18,11 @@
: toolbar_has_focus_(false),
ALLOW_THIS_IN_INITIALIZER_LIST(method_factory_(this)),
focus_manager_(NULL),
- home_key_(app::VKEY_HOME, false, false, false),
- end_key_(app::VKEY_END, false, false, false),
- escape_key_(app::VKEY_ESCAPE, false, false, false),
- left_key_(app::VKEY_LEFT, false, false, false),
- right_key_(app::VKEY_RIGHT, false, false, false),
+ home_key_(base::VKEY_HOME, false, false, false),
+ end_key_(base::VKEY_END, false, false, false),
+ escape_key_(base::VKEY_ESCAPE, false, false, false),
+ left_key_(base::VKEY_LEFT, false, false, false),
+ right_key_(base::VKEY_RIGHT, false, false, false),
last_focused_view_storage_id_(-1) {
focus_search_.reset(new views::FocusSearch(this, true, true));
}
@@ -148,27 +148,27 @@
views::View* focused_view = focus_manager_->GetFocusedView();
if ((focused_view->GetClassName() == LocationBarView::kViewClassName ||
focused_view->GetClassName() == views::NativeViewHost::kViewClassName) &&
- (accelerator.GetKeyCode() == app::VKEY_LEFT ||
- accelerator.GetKeyCode() == app::VKEY_RIGHT)) {
+ (accelerator.GetKeyCode() == base::VKEY_LEFT ||
+ accelerator.GetKeyCode() == base::VKEY_RIGHT)) {
return false;
}
switch (accelerator.GetKeyCode()) {
- case app::VKEY_ESCAPE:
+ case base::VKEY_ESCAPE:
RemoveToolbarFocus();
RestoreLastFocusedView();
return true;
- case app::VKEY_LEFT:
+ case base::VKEY_LEFT:
focus_manager_->AdvanceFocus(true);
return true;
- case app::VKEY_RIGHT:
+ case base::VKEY_RIGHT:
focus_manager_->AdvanceFocus(false);
return true;
- case app::VKEY_HOME:
+ case base::VKEY_HOME:
focus_manager_->SetFocusedViewWithReason(
GetFirstFocusableChild(), views::FocusManager::kReasonFocusTraversal);
return true;
- case app::VKEY_END:
+ case base::VKEY_END:
focus_manager_->SetFocusedViewWithReason(
GetLastFocusableChild(), views::FocusManager::kReasonFocusTraversal);
return true;
« no previous file with comments | « chrome/browser/views/accelerator_table_gtk.cc ('k') | chrome/browser/views/bookmark_bar_view_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698