Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Side by Side Diff: chrome/browser/views/location_bar/location_bar_view.cc

Issue 3337006: Revert 58388 - Revert 58215 - Revert 58186 - Move the keyboard files from bas... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 10 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2010 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2010 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/views/location_bar/location_bar_view.h" 5 #include "chrome/browser/views/location_bar/location_bar_view.h"
6 6
7 #if defined(OS_LINUX) 7 #if defined(OS_LINUX)
8 #include <gtk/gtk.h> 8 #include <gtk/gtk.h>
9 #endif 9 #endif
10 10
(...skipping 925 matching lines...) Expand 10 before | Expand all | Expand 10 after
936 } 936 }
937 937
938 #if defined(OS_WIN) 938 #if defined(OS_WIN)
939 return location_entry_->SkipDefaultKeyEventProcessing(e); 939 return location_entry_->SkipDefaultKeyEventProcessing(e);
940 #else 940 #else
941 // TODO(jcampan): We need to refactor the code of 941 // TODO(jcampan): We need to refactor the code of
942 // AutocompleteEditViewWin::SkipDefaultKeyEventProcessing into this class so 942 // AutocompleteEditViewWin::SkipDefaultKeyEventProcessing into this class so
943 // it can be shared between Windows and Linux. 943 // it can be shared between Windows and Linux.
944 // For now, we just override back-space and tab keys, as back-space is the 944 // For now, we just override back-space and tab keys, as back-space is the
945 // accelerator for back navigation and tab key is used by some input methods. 945 // accelerator for back navigation and tab key is used by some input methods.
946 if (e.GetKeyCode() == app::VKEY_BACK || 946 if (e.GetKeyCode() == base::VKEY_BACK ||
947 views::FocusManager::IsTabTraversalKeyEvent(e)) 947 views::FocusManager::IsTabTraversalKeyEvent(e))
948 return true; 948 return true;
949 return false; 949 return false;
950 #endif 950 #endif
951 } 951 }
952 952
953 bool LocationBarView::GetAccessibleRole(AccessibilityTypes::Role* role) { 953 bool LocationBarView::GetAccessibleRole(AccessibilityTypes::Role* role) {
954 DCHECK(role); 954 DCHECK(role);
955 955
956 *role = AccessibilityTypes::ROLE_GROUPING; 956 *role = AccessibilityTypes::ROLE_GROUPING;
(...skipping 127 matching lines...) Expand 10 before | Expand all | Expand 10 after
1084 1084
1085 NOTREACHED(); 1085 NOTREACHED();
1086 } 1086 }
1087 1087
1088 void LocationBarView::OnTemplateURLModelChanged() { 1088 void LocationBarView::OnTemplateURLModelChanged() {
1089 template_url_model_->RemoveObserver(this); 1089 template_url_model_->RemoveObserver(this);
1090 template_url_model_ = NULL; 1090 template_url_model_ = NULL;
1091 ShowFirstRunBubble(bubble_type_); 1091 ShowFirstRunBubble(bubble_type_);
1092 } 1092 }
1093 1093
OLDNEW
« no previous file with comments | « chrome/browser/views/keyword_editor_view.cc ('k') | chrome/browser/views/location_bar/page_action_image_view.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698