Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Issue 3337004: Fix a chrome browser crash observed in chrome frame reliability test runs. Th... (Closed)

Created:
10 years, 3 months ago by ananta
Modified:
9 years, 6 months ago
Reviewers:
jam
CC:
chromium-reviews, darin-cc_chromium.org, jam, Paweł Hajdan Jr.
Visibility:
Public.

Description

Fix a chrome browser crash observed in chrome frame reliability test runs. The crash occurs when the automation channel is being torn down and a Send on the channel is attempted after the channel has been closed. We crash while dereferencing a NULL channel pointer in OnSendMessage task. Fix is to add a check for the same. Fixes bug http://code.google.com/p/chromium/issues/detail?can=2&q=54115 Bug=54115 Test=Covered by new ipc sync channel test. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=58408

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 1

Patch Set 4 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -1 line) Patch
M ipc/ipc_channel_proxy.cc View 1 2 3 1 chunk +5 lines, -0 lines 0 comments Download
M ipc/ipc_sync_channel.cc View 1 chunk +1 line, -0 lines 0 comments Download
M ipc/ipc_sync_channel_unittest.cc View 1 2 3 3 chunks +52 lines, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
ananta
10 years, 3 months ago (2010-09-01 23:55:37 UTC) #1
jam
http://codereview.chromium.org/3337004/diff/9001/4002 File ipc/ipc_channel_proxy.cc (right): http://codereview.chromium.org/3337004/diff/9001/4002#newcode158 ipc/ipc_channel_proxy.cc:158: if (!channel_ || !channel_->Send(message)) do we really want to ...
10 years, 3 months ago (2010-09-02 17:55:39 UTC) #2
jam
10 years, 3 months ago (2010-09-02 19:24:36 UTC) #3
lgtm

Powered by Google App Engine
This is Rietveld 408576698