Issue 3336016: update_engine_client: Clarify error message.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3336016: update_engine_client: Clarify error message. (Closed)

Created:
10 years, 3 months ago by Kenneth Waters

Modified:
9 years, 7 months ago

Reviewers:
adlr

CC:
chromium-os-reviews_chromium.org, petkov, adlr

Base URL:
ssh://git@gitrw.chromium.org:9222/update_engine.git

Visibility:
Public.

Description

update_engine_client: Clarify error message. BUG=None TEST=Built and run on tegra2_dev-board

Patch Set 1 #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	update_engine_client.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

adlr

10 years, 3 months ago (2010-09-10 00:24:12 UTC) #2

LGTM

On Thu, Sep 9, 2010 at 1:32 PM, <kwaters@chromium.org> wrote:

> Reviewers: adlr,
>
> Description:
> update_engine_client: Clarify error message.
>
> BUG=None
> TEST=Built and run on tegra2_dev-board
>
> Please review this at http://codereview.chromium.org/3336016/show
>
> SVN Base: ssh://git@gitrw.chromium.org:9222/update_engine.git
>
> Affected files:
>  M update_engine_client.cc
>
>
> Index: update_engine_client.cc
> diff --git a/update_engine_client.cc b/update_engine_client.cc
> index
>
a55820ae94f28eb781f198c215dcf92f8031e697..7bbc62f6de5edfc38764409adabe60903260df85
> 100644
> --- a/update_engine_client.cc
> +++ b/update_engine_client.cc
> @@ -49,7 +49,8 @@ bool GetProxy(DBusGProxy** out_proxy) {
>                                           kUpdateEngineServiceInterface,
>                                           &error);
>   if (!proxy) {
> -    LOG(FATAL) << "Error getting proxy: " << GetGErrorMessage(error);
> +    LOG(FATAL) << "Error getting dbus proxy for "
> +               << kUpdateEngineServiceName << ": " <<
> GetGErrorMessage(error);
>   }
>   *out_proxy = proxy;
>   return true;
>
>
>

Expand Messages | Collapse Messages