Issue 3336015: Add the infrastructure necessary to support annotated stdout.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3336015: Add the infrastructure necessary to support annotated stdout. (Closed)

Created:
10 years, 3 months ago by M-A Ruel

Modified:
9 years, 7 months ago

Reviewers:
bradnelson, bradn

CC:
chromium-reviews, M-A Ruel

Visibility:
Public.

Description

Add the infrastructure necessary to support annotated stdout. Simplify ExecutionQueue.run() by moving code into utility functions. Reduce the amount of code in WorkerThread.run() to improve reliability. Don't trap exceptions in single-threaded usage! BUG=54084 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=58974

Patch Set 1 #

Patch Set 2 : Update unit tests! #

Total comments: 2

Patch Set 3 : add progress.update() #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+75 lines, -46 lines)			Patch
M	gclient.py	View		3 chunks	+3 lines, -4 lines	0 comments	Download
M	gclient_utils.py	View	1 2	6 chunks	+70 lines, -40 lines	0 comments	Download
M	tests/gclient_utils_test.py	View		1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

bradn

http://codereview.chromium.org/3336015/diff/3001/4002 File gclient_utils.py (right): http://codereview.chromium.org/3336015/diff/3001/4002#newcode609 gclient_utils.py:609: self.item.run(*self.args, **self.kwargs) Don't you still need to update progress?

10 years, 3 months ago (2010-09-09 05:17:22 UTC) #2

M-A Ruel

10 years, 3 months ago (2010-09-09 17:17:47 UTC) #3

LGTM

Expand Messages | Collapse Messages