Issue 3336001: Make JSON.stringify not quote non-ASCII characters. Fix bug 855.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3336001: Make JSON.stringify not quote non-ASCII characters. Fix bug 855. (Closed)

Created:
10 years, 3 months ago by Lasse Reichstein

Modified:
9 years, 6 months ago

Reviewers:
Rico

CC:
v8-dev

Visibility:
Public.

Description

Make JSON.stringify not quote non-ASCII characters. Fix bug 855. Committed: http://code.google.com/p/v8/source/detail?r=5398

Patch Set 1 #

Total comments: 2

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+36 lines, -9 lines)			Patch
	M	src/json.js	View		2 chunks	+7 lines, -9 lines	0 comments	Download
	M	test/mjsunit/json.js	View		1 chunk	+29 lines, -0 lines	2 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Rico

10 years, 3 months ago (2010-09-01 14:48:20 UTC) #2

LGTM

http://codereview.chromium.org/3336001/diff/1/3
File test/mjsunit/json.js (right):

http://codereview.chromium.org/3336001/diff/1/3#newcode340
test/mjsunit/json.js:340: expected = "\\u000" + i.toString(16);
Indention off

http://codereview.chromium.org/3336001/diff/1/3#newcode342
test/mjsunit/json.js:342: expected = "\\u00" + i.toString(16);
Indention off

Expand Messages | Collapse Messages