Issue 3335018: vboot_reference: move tests into client/ and also put the server test in here

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3335018: vboot_reference: move tests into client/ and also put the server test in here (Closed)

Created:
10 years, 3 months ago by zbehan

Modified:
9 years, 7 months ago

Reviewers:
Luigi Semenzato, ericli, gauravsh

CC:
chromium-os-reviews_chromium.org, Randall Spangler, gauravsh, Bill Richardson

Base URL:
ssh://git@gitrw.chromium.org:9222/vboot_reference.git

Visibility:
Public.

Description

vboot_reference: move tests into client/ and also put the server test in here * Adjusted the path in VbootCrypto Makefile Change-Id: I2485c3940f4d3894694c3e834ed79b1b3f58d4bc BUG= TEST=

Patch Set 1 #

Total comments: 1

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+85 lines, --4 lines)			Patch
A +	autotest/client/firmware_VbootCrypto/control	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	autotest/client/firmware_VbootCrypto/firmware_VbootCrypto.py	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	autotest/client/firmware_VbootCrypto/src/Makefile	View	1 chunk	+1 line, -1 line	0 comments	Download
A +	autotest/client/hardware_TPMFirmware/control	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	autotest/client/hardware_TPMFirmware/hardware_TPMFirmware.py	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A +	autotest/client/hardware_TPMFirmware/src/Makefile	View	0 chunks	+-1 lines, --1 lines	0 comments	Download
A	autotest/server/hardware_TPMFirmwareServer/control	View	1 chunk	+18 lines, -0 lines	1 comment	Download
A	autotest/server/hardware_TPMFirmwareServer/hardware_TPMFirmwareServer.py	View	1 chunk	+71 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

gauravsh

lgtm http://codereview.chromium.org/3335018/diff/1/8 File autotest/server/hardware_TPMFirmwareServer/control (right): http://codereview.chromium.org/3335018/diff/1/8#newcode1 autotest/server/hardware_TPMFirmwareServer/control:1: # Copyright (c) 2009 The Chromium OS Authors. ...

10 years, 3 months ago (2010-09-11 07:26:41 UTC) #2

Luigi Semenzato

10 years, 3 months ago (2010-09-13 16:07:59 UTC) #3

LGTM

On 2010/09/11 07:26:41, gauravsh wrote:
> lgtm
> 
> http://codereview.chromium.org/3335018/diff/1/8
> File autotest/server/hardware_TPMFirmwareServer/control (right):
> 
> http://codereview.chromium.org/3335018/diff/1/8#newcode1
> autotest/server/hardware_TPMFirmwareServer/control:1: # Copyright (c) 2009 The
> Chromium OS Authors. All rights reserved.
> 2010

Expand Messages | Collapse Messages