Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issue 3335016: Same as 3305029. Fixed compilation error on Linux. Unfortunately try does not... (Closed)

Created:
10 years, 3 months ago by gene1
Modified:
9 years, 7 months ago
Reviewers:
jam
CC:
chromium-reviews, jam, darin-cc_chromium.org, stuartmorgan+watch_chromium.org, sanjeevr, brettw
Visibility:
Public.

Description

Same as 3305029. Fixed compilation error on Linux. Unfortunately try does not work for resources. GCC has troubles with arraysize() for structures in the different namespace and with annonymous structures. The only difference from 3305029 is in pepper_private.cc. Added PDF resources to Chrome. Added private interface to access resources from pepper plugin. Added example to PDF srting resource. BUG=54322 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=59150

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+130 lines, -1 line) Patch
M webkit/glue/plugins/pepper_private.cc View 1 4 chunks +76 lines, -0 lines 0 comments Download
M webkit/glue/plugins/ppb_private.h View 2 chunks +30 lines, -0 lines 0 comments Download
A webkit/glue/resources/pdf_button_fth.png View Binary file 0 comments Download
A webkit/glue/resources/pdf_button_fth_hover.png View Binary file 0 comments Download
A webkit/glue/resources/pdf_button_fth_pressed.png View Binary file 0 comments Download
A webkit/glue/resources/pdf_button_ftw.png View Binary file 0 comments Download
A webkit/glue/resources/pdf_button_ftw_hover.png View Binary file 0 comments Download
A webkit/glue/resources/pdf_button_ftw_pressed.png View Binary file 0 comments Download
A webkit/glue/resources/pdf_button_zoomin.png View Binary file 0 comments Download
A webkit/glue/resources/pdf_button_zoomin_hover.png View Binary file 0 comments Download
A webkit/glue/resources/pdf_button_zoomin_pressed.png View Binary file 0 comments Download
A webkit/glue/resources/pdf_button_zoomout.png View Binary file 0 comments Download
A webkit/glue/resources/pdf_button_zoomout_hover.png View Binary file 0 comments Download
A webkit/glue/resources/pdf_button_zoomout_pressed.png View Binary file 0 comments Download
A webkit/glue/resources/pdf_thumbnail_0.png View Binary file 0 comments Download
A webkit/glue/resources/pdf_thumbnail_1.png View Binary file 0 comments Download
A webkit/glue/resources/pdf_thumbnail_2.png View Binary file 0 comments Download
A webkit/glue/resources/pdf_thumbnail_3.png View Binary file 0 comments Download
A webkit/glue/resources/pdf_thumbnail_4.png View Binary file 0 comments Download
A webkit/glue/resources/pdf_thumbnail_5.png View Binary file 0 comments Download
A webkit/glue/resources/pdf_thumbnail_6.png View Binary file 0 comments Download
A webkit/glue/resources/pdf_thumbnail_7.png View Binary file 0 comments Download
A webkit/glue/resources/pdf_thumbnail_8.png View Binary file 0 comments Download
A webkit/glue/resources/pdf_thumbnail_9.png View Binary file 0 comments Download
A webkit/glue/resources/pdf_thumbnail_num_background.png View Binary file 0 comments Download
M webkit/glue/webkit_resources.grd View 1 chunk +23 lines, -0 lines 0 comments Download
M webkit/glue/webkit_strings.grd View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
gene
10 years, 3 months ago (2010-09-10 18:51:46 UTC) #1
jam
10 years, 3 months ago (2010-09-10 19:44:58 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698