Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3618)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/common/gpu_video_common.cc

Issue 3335014: Added FakeGlVideoDecodeEngine to exercise the IPC protocol for hardware video decoding (Closed)
Patch Set: compile man... Created 10 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/common/gpu_video_common.h ('k') | chrome/gpu/gpu_channel.cc » ('j') | chrome/gpu/media/fake_gl_video_decode_engine.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/common/gpu_video_common.cc
diff --git a/chrome/common/gpu_video_common.cc b/chrome/common/gpu_video_common.cc
index 2042c1b05eca0200922c2b2c68c67dec90cf6951..928bb4441d8bc3e5c80c4a2efbea22586203436d 100644
--- a/chrome/common/gpu_video_common.cc
+++ b/chrome/common/gpu_video_common.cc
@@ -8,16 +8,16 @@ namespace IPC {
void ParamTraits<GpuVideoServiceInfoParam>::Write(
Message* m, const GpuVideoServiceInfoParam& p) {
- m->WriteInt(p.video_service_route_id_);
- m->WriteInt(p.video_service_host_route_id_);
- m->WriteInt(p.service_available_);
+ m->WriteInt(p.video_service_route_id);
+ m->WriteInt(p.video_service_host_route_id);
+ m->WriteInt(p.service_available);
}
bool ParamTraits<GpuVideoServiceInfoParam>::Read(
const Message* m, void** iter, GpuVideoServiceInfoParam* r) {
- if (!m->ReadInt(iter, &r->video_service_route_id_) ||
- !m->ReadInt(iter, &r->video_service_host_route_id_) ||
- !m->ReadInt(iter, &r->service_available_))
+ if (!m->ReadInt(iter, &r->video_service_route_id) ||
+ !m->ReadInt(iter, &r->video_service_host_route_id) ||
+ !m->ReadInt(iter, &r->service_available))
return false;
return true;
}
@@ -25,9 +25,9 @@ bool ParamTraits<GpuVideoServiceInfoParam>::Read(
void ParamTraits<GpuVideoServiceInfoParam>::Log(
const GpuVideoServiceInfoParam& p, std::string* l) {
l->append(StringPrintf("(%d, %d, %d)",
- p.video_service_route_id_,
- p.video_service_host_route_id_,
- p.service_available_));
+ p.video_service_route_id,
+ p.video_service_host_route_id,
+ p.service_available));
}
///////////////////////////////////////////////////////////////////////////////
@@ -62,76 +62,76 @@ void ParamTraits<GpuVideoDecoderInfoParam>::Log(
void ParamTraits<GpuVideoDecoderInitParam>::Write(
Message* m, const GpuVideoDecoderInitParam& p) {
- m->WriteInt(p.codec_id_);
- m->WriteInt(p.width_);
- m->WriteInt(p.height_);
+ m->WriteInt(p.codec_id);
+ m->WriteInt(p.width);
+ m->WriteInt(p.height);
}
bool ParamTraits<GpuVideoDecoderInitParam>::Read(
const Message* m, void** iter, GpuVideoDecoderInitParam* r) {
- if (!m->ReadInt(iter, &r->codec_id_) ||
- !m->ReadInt(iter, &r->width_) ||
- !m->ReadInt(iter, &r->height_))
+ if (!m->ReadInt(iter, &r->codec_id) ||
+ !m->ReadInt(iter, &r->width) ||
+ !m->ReadInt(iter, &r->height))
return false;
return true;
}
void ParamTraits<GpuVideoDecoderInitParam>::Log(
const GpuVideoDecoderInitParam& p, std::string* l) {
- l->append(StringPrintf("(%d, %d %d)", p.codec_id_, p.width_, p.height_));
+ l->append(StringPrintf("(%d, %d %d)", p.codec_id, p.width, p.height));
}
///////////////////////////////////////////////////////////////////////////////
void ParamTraits<GpuVideoDecoderInitDoneParam>::Write(
Message* m, const GpuVideoDecoderInitDoneParam& p) {
- m->WriteInt(p.success_);
- m->WriteInt(p.stride_);
- m->WriteInt(p.format_);
- m->WriteInt(p.surface_type_);
- m->WriteInt(p.input_buffer_size_);
- m->WriteInt(p.output_buffer_size_);
+ m->WriteInt(p.success);
+ m->WriteInt(p.stride);
+ m->WriteInt(p.format);
+ m->WriteInt(p.surface_type);
+ m->WriteInt(p.input_buffer_size);
+ m->WriteInt(p.output_buffer_size);
IPC::ParamTraits<base::SharedMemoryHandle>::Write(
- m, p.input_buffer_handle_);
+ m, p.input_buffer_handle);
IPC::ParamTraits<base::SharedMemoryHandle>::Write(
- m, p.output_buffer_handle_);
+ m, p.output_buffer_handle);
}
bool ParamTraits<GpuVideoDecoderInitDoneParam>::Read(
const Message* m, void** iter, GpuVideoDecoderInitDoneParam* r) {
- if (!m->ReadInt(iter, &r->success_) ||
- !m->ReadInt(iter, &r->stride_) ||
- !m->ReadInt(iter, &r->format_) ||
- !m->ReadInt(iter, &r->surface_type_) ||
- !m->ReadInt(iter, &r->input_buffer_size_) ||
- !m->ReadInt(iter, &r->output_buffer_size_) ||
+ if (!m->ReadInt(iter, &r->success) ||
+ !m->ReadInt(iter, &r->stride) ||
+ !m->ReadInt(iter, &r->format) ||
+ !m->ReadInt(iter, &r->surface_type) ||
+ !m->ReadInt(iter, &r->input_buffer_size) ||
+ !m->ReadInt(iter, &r->output_buffer_size) ||
!IPC::ParamTraits<base::SharedMemoryHandle>::Read(
- m, iter, &r->input_buffer_handle_) ||
+ m, iter, &r->input_buffer_handle) ||
!IPC::ParamTraits<base::SharedMemoryHandle>::Read(
- m, iter, &r->output_buffer_handle_))
+ m, iter, &r->output_buffer_handle))
return false;
return true;
}
void ParamTraits<GpuVideoDecoderInitDoneParam>::Log(
const GpuVideoDecoderInitDoneParam& p, std::string* l) {
- l->append(StringPrintf("(%d)", p.stride_));
+ l->append(StringPrintf("(%d)", p.stride));
}
///////////////////////////////////////////////////////////////////////////////
void ParamTraits<GpuVideoDecoderInputBufferParam>::Write(
Message* m, const GpuVideoDecoderInputBufferParam& p) {
- m->WriteInt64(p.timestamp_);
- m->WriteInt(p.offset_);
- m->WriteInt(p.size_);
+ m->WriteInt64(p.timestamp);
+ m->WriteInt(p.offset);
+ m->WriteInt(p.size);
}
bool ParamTraits<GpuVideoDecoderInputBufferParam>::Read(
const Message* m, void** iter, GpuVideoDecoderInputBufferParam* r) {
- if (!m->ReadInt64(iter, &r->timestamp_) ||
- !m->ReadInt(iter, &r->offset_) ||
- !m->ReadInt(iter, &r->size_))
+ if (!m->ReadInt64(iter, &r->timestamp) ||
+ !m->ReadInt(iter, &r->offset) ||
+ !m->ReadInt(iter, &r->size))
return false;
return true;
}
@@ -139,34 +139,37 @@ bool ParamTraits<GpuVideoDecoderInputBufferParam>::Read(
void ParamTraits<GpuVideoDecoderInputBufferParam>::Log(
const GpuVideoDecoderInputBufferParam& p, std::string* l) {
l->append(StringPrintf("(%d %d %d)",
- static_cast<int>(p.timestamp_),
- p.offset_, p.size_));
+ static_cast<int>(p.timestamp),
+ p.offset, p.size));
}
///////////////////////////////////////////////////////////////////////////////
void ParamTraits<GpuVideoDecoderOutputBufferParam>::Write(
Message* m, const GpuVideoDecoderOutputBufferParam& p) {
- m->WriteInt64(p.timestamp_);
- m->WriteInt64(p.duration_);
- m->WriteInt(p.flags_);
+ m->WriteInt64(p.timestamp);
+ m->WriteInt64(p.duration);
+ m->WriteInt(p.flags);
+ m->WriteInt(p.texture);
}
bool ParamTraits<GpuVideoDecoderOutputBufferParam>::Read(
const Message* m, void** iter, GpuVideoDecoderOutputBufferParam* r) {
- if (!m->ReadInt64(iter, &r->timestamp_) ||
- !m->ReadInt64(iter, &r->duration_) ||
- !m->ReadInt(iter, &r->flags_))
+ if (!m->ReadInt64(iter, &r->timestamp) ||
+ !m->ReadInt64(iter, &r->duration) ||
+ !m->ReadInt(iter, &r->flags) ||
+ !m->ReadInt(iter, &r->texture))
return false;
return true;
}
void ParamTraits<GpuVideoDecoderOutputBufferParam>::Log(
const GpuVideoDecoderOutputBufferParam& p, std::string* l) {
- l->append(StringPrintf("(%d %d) %x",
- static_cast<int>(p.timestamp_),
- static_cast<int>(p.duration_),
- p.flags_));
+ l->append(StringPrintf("(%d %d) %x texture = x%d",
+ static_cast<int>(p.timestamp),
+ static_cast<int>(p.duration),
+ p.flags,
+ p.texture));
}
///////////////////////////////////////////////////////////////////////////////
@@ -192,21 +195,21 @@ void ParamTraits<GpuVideoDecoderErrorInfoParam>::Log(
void ParamTraits<GpuVideoDecoderFormatChangeParam>::Write(
Message* m, const GpuVideoDecoderFormatChangeParam& p) {
- m->WriteInt(p.input_buffer_size_);
- m->WriteInt(p.output_buffer_size_);
+ m->WriteInt(p.input_buffer_size);
+ m->WriteInt(p.output_buffer_size);
}
bool ParamTraits<GpuVideoDecoderFormatChangeParam>::Read(
const Message* m, void** iter, GpuVideoDecoderFormatChangeParam* r) {
- if (!m->ReadInt(iter, &r->input_buffer_size_) ||
- !m->ReadInt(iter, &r->output_buffer_size_))
+ if (!m->ReadInt(iter, &r->input_buffer_size) ||
+ !m->ReadInt(iter, &r->output_buffer_size))
return false;
return true;
}
void ParamTraits<GpuVideoDecoderFormatChangeParam>::Log(
const GpuVideoDecoderFormatChangeParam& p, std::string* l) {
- l->append(StringPrintf("(%d %d)", p.input_buffer_size_,
- p.output_buffer_size_));
+ l->append(StringPrintf("(%d %d)", p.input_buffer_size,
+ p.output_buffer_size));
}
};
« no previous file with comments | « chrome/common/gpu_video_common.h ('k') | chrome/gpu/gpu_channel.cc » ('j') | chrome/gpu/media/fake_gl_video_decode_engine.h » ('J')

Powered by Google App Engine
This is Rietveld 408576698