Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 3335004: Whitespace/tab cleanup for cros_workon (Closed)

Created:
10 years, 3 months ago by kliegs
Modified:
9 years ago
Reviewers:
zbehan
CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa
Visibility:
Public.

Description

Whitespace/tab cleanup for cros_workon Change-Id: I17379dc302fcad0f3a7f59771c48d86df320c0d0 BUG=NONE TEST=Manual diff inspection. Ran scripts and confirmed no syntax errors.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -16 lines) Patch
M cros_workon View 1 chunk +16 lines, -16 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
kliegs
10 years, 3 months ago (2010-09-03 19:34:42 UTC) #1
zbehan
10 years, 3 months ago (2010-09-03 20:20:57 UTC) #2
LGTM

On Fri, Sep 3, 2010 at 12:34 PM, <kliegs@chromium.org> wrote:

> Reviewers: zbehan,
>
> Description:
> Whitespace/tab cleanup for cros_workon
>
> Change-Id: I17379dc302fcad0f3a7f59771c48d86df320c0d0
>
> BUG=
> TEST=Manual diff inspection.  Ran scripts and confirmed no syntax errors.
>
> Please review this at http://codereview.chromium.org/3335004/show
>
> SVN Base: ssh://git@gitrw.chromium.org:9222/crosutils.git
>
> Affected files:
>  M cros_workon
>
>
> Index: cros_workon
> diff --git a/cros_workon b/cros_workon
> index
>
e9400da47dc31b26289c40f44d3a58100aaeada3..d23756786d89a8be46bce970b4efa4dfd3fdd8a9
> 100755
> --- a/cros_workon
> +++ b/cros_workon
> @@ -150,22 +150,22 @@ regen_manifest_and_sync() {
>
>   # ensure we don't clobber existing manifest entries
>   if [ -f "${local_manifest}" ]; then
> -      grep -q -i "<remote" "${local_manifest}"
> -      if [ $? -ne 1 ]; then
> -         die "Your local manifest will be clobbered running cros_workon.
> You can not have any <remote> tags at all."
> -      fi
> -      sed -ne '/^[[:space:]]\+[^[:space:]]/q1' "${local_manifest}"
> -      if [ $? -ne 0 ]; then
> -         die "Your local manifest will be clobbered running cros_workon.
> You can not have any tags that span multiple lines or are indented."
> -      fi
> -      egrep -q "^[^<]" "${local_manifest}"
> -      if [ $? -ne 1 ]; then
> -         die "Your local manifest will be clobbered running cros_workon.
> You can not have any tags that span multiple lines"
> -      fi
> -      grep -v "<project" "${local_manifest}" | grep -q -i "<project"
> -      if [ $? -eq 0 ]; then
> -         die "Your local manifest has mixed case tags for project.  You
> can not have mixed case tags"
> -      fi
> +    grep -q -i "<remote" "${local_manifest}"
> +    if [ $? -ne 1 ]; then
> +      die "Your local manifest will be clobbered running cros_workon. You
> can not have any <remote> tags at all."
> +    fi
> +    sed -ne '/^[[:space:]]\+[^[:space:]]/q1' "${local_manifest}"
> +    if [ $? -ne 0 ]; then
> +      die "Your local manifest will be clobbered running cros_workon. You
> can not have any tags that span multiple lines or are indented."
> +    fi
> +    egrep -q "^[^<]" "${local_manifest}"
> +    if [ $? -ne 1 ]; then
> +      die "Your local manifest will be clobbered running cros_workon. You
> can not have any tags that span multiple lines"
> +    fi
> +    grep -v "<project" "${local_manifest}" | grep -q -i "<project"
> +    if [ $? -eq 0 ]; then
> +      die "Your local manifest has mixed case tags for project.  You can
> not have mixed case tags"
> +    fi
>   fi
>   # preserve old manifest entries
>   [ -f "${local_manifest}" ] && \
>
>
>

Powered by Google App Engine
This is Rietveld 408576698