Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Unified Diff: tests/fake_repos.py

Issue 3333028: Improve the testing situation on Windows.... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools/
Patch Set: Created 10 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « presubmit_support.py ('k') | tests/gclient_scm_test.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/fake_repos.py
===================================================================
--- tests/fake_repos.py (revision 59107)
+++ tests/fake_repos.py (working copy)
@@ -286,10 +286,14 @@
def setUpSVN(self):
"""Creates subversion repositories and start the servers."""
if self.svnserve:
- return
+ return True
self.setUp()
root = join(self.repos_dir, 'svn')
- check_call(['svnadmin', 'create', root])
+ try:
+ check_call(['svnadmin', 'create', root])
+ except OSError:
+ self.svn_enabled = False
+ return False
write(join(root, 'conf', 'svnserve.conf'),
'[general]\n'
'anon-access = read\n'
@@ -306,6 +310,7 @@
cmd.append('--listen-host=127.0.0.1')
self.svnserve = Popen(cmd, cwd=root)
self.populateSvn()
+ return True
def populateSvn(self):
"""Creates a few revisions of changes including DEPS files."""
« no previous file with comments | « presubmit_support.py ('k') | tests/gclient_scm_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698