Issue 3333019: Back out r58711. It appears to have caused video/media-related ui_tests...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3333019: Back out r58711. It appears to have caused video/media-related ui_tests... (Closed)

Created:
10 years, 3 months ago by Mark Mentovai

Modified:
9 years, 7 months ago

Reviewers:
Vangelis Kokkevis

CC:
chromium-reviews, pam+watch_chromium.org, ben+cc_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Back out r58711. It appears to have caused video/media-related ui_tests failures on Windows: MediaTest.VideoBearTheora MediaTest.VideoBearSilentTheora MediaTest.VideoBearWebm MediaTest.VideoBearSilentWebm UILayoutTest.MediaUILayoutTest BUG=54469 TEST=tree Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=58730

Patch Set 1 #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+15 lines, -36 lines)			Patch
M	chrome/app/chrome_dll_main.cc	View	1 chunk	+0 lines, -15 lines	0 comments	Download
M	chrome/browser/renderer_host/browser_render_process_host.cc	View	2 chunks	+3 lines, -2 lines	0 comments	Download
M	chrome/browser/tab_contents/render_view_host_delegate_helper.cc	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	chrome/common/chrome_switches.h	View	3 chunks	+1 line, -2 lines	0 comments	Download
M	chrome/common/chrome_switches.cc	View	4 chunks	+3 lines, -9 lines	0 comments	Download
M	chrome/common/sandbox_init_wrapper_mac.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/common/sandbox_policy.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/renderer/render_thread.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/renderer/render_view.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/renderer/webgraphicscontext3d_command_buffer_impl.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Mark Mentovai

Test failures and you weren’t around to respond. Backed out TBR.

10 years, 3 months ago (2010-09-07 19:10:57 UTC) #2

vangelis

10 years, 3 months ago (2010-09-07 20:37:03 UTC) #3

Sorry about that... Looking into it right now to find a workaround!

Vangelis


On Tue, Sep 7, 2010 at 12:10 PM, <mark@chromium.org> wrote:

> Test failures and you weren’t around to respond. Backed out TBR.
>
>
> http://codereview.chromium.org/3333019/show
>

Expand Messages | Collapse Messages