Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(864)

Issue 3331007: remote_cp renamed to remote_cp_to. *shrug* (Closed)

Created:
10 years, 3 months ago by Paul Stewart
Modified:
9 years, 7 months ago
Reviewers:
kmixter1, Sam Leffler
CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa
Base URL:
ssh://gitrw.chromium.org/crosutils.git
Visibility:
Public.

Description

remote_cp renamed to remote_cp_to. *shrug* This function was renamed, so I renamed my reference to it. BUG=none TEST=Reran cros_package_to_live

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M bin/cros_package_to_live View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
Paul Stewart
10 years, 3 months ago (2010-09-02 00:13:35 UTC) #1
kmixter1
10 years, 3 months ago (2010-09-02 01:26:09 UTC) #2
LGTM - sorry about that.

On Wed, Sep 1, 2010 at 5:13 PM,  <pstew@chromium.org> wrote:
> Reviewers: kmixter1, Sam Leffler,
>
> Description:
> remote_cp renamed to remote_cp_to.  *shrug*
>
> This function was renamed, so I renamed my reference to it.
>
> BUG=none
> TEST=Reran cros_package_to_live
>
> Please review this at http://codereview.chromium.org/3331007/show
>
> SVN Base: ssh://gitrw.chromium.org/crosutils.git
>
> Affected files:
>  M bin/cros_package_to_live
>
>
> Index: bin/cros_package_to_live
> diff --git a/bin/cros_package_to_live b/bin/cros_package_to_live
> index
>
5cbfe030e3ab1e491c9b5fbe48b4e68172ed30aa..d1d9480448c1290709931424eabb0ee9f4d6e5b7
> 100755
> --- a/bin/cros_package_to_live
> +++ b/bin/cros_package_to_live
> @@ -74,7 +74,7 @@ for pkg in $@; do
>
>     remote_sh "mktemp -d /tmp/cros_package_to_live.XXXX"
>     temp_dir=$REMOTE_OUT
> -    remote_cp "${latest_pkg}" "${temp_dir}"
> +    remote_cp_to "${latest_pkg}" "${temp_dir}"
>     remote_sh "mount -o remount,rw /"
>     remote_sh "mkdir -p /usr/portage/packages/${pkg_dir} &&
>                mv ${temp_dir}/${pkg_name} /usr/portage/packages/${pkg_dir}
> &&
>
>
>

Powered by Google App Engine
This is Rietveld 408576698