chrome/browser/policy/config_dir_policy_provider.cc - Issue 3331001: Readability review.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/policy/config_dir_policy_provider.cc

Issue 3331001: Readability review. (Closed) Base URL: http://src.chromium.org/git/chromium.git

Patch Set: Address comments. Created 10 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/policy/config_dir_policy_provider.cc

diff --git a/chrome/browser/policy/config_dir_policy_provider.cc b/chrome/browser/policy/config_dir_policy_provider.cc

index 7f1a7387eea57186a380e702f62af29f44db7e45..1890debe62e053f9be38f85ff1c2e76f0a35b370 100644

--- a/chrome/browser/policy/config_dir_policy_provider.cc

+++ b/chrome/browser/policy/config_dir_policy_provider.cc

@@ -8,8 +8,11 @@

#include "base/file_util.h"

#include "base/logging.h"

+#include "base/message_loop.h"

+#include "base/task.h"

#include "base/utf_string_conversions.h"

#include "base/values.h"

+#include "chrome/browser/chrome_thread.h"

#include "chrome/common/json_value_serializer.h"

namespace {

@@ -222,7 +225,7 @@ void PolicyDirWatcher::InitWatcher(

return;

}

- if (!Watch(loader->config_dir(), loader.get()))

+ if (!watcher_.Watch(loader->config_dir(), loader.get()))

loader->OnError();

// There might have been changes to the directory in the time between