Issue 333041: Take 2 at browser_sync::ExtensionsActivityMonitor....

Issue 333041: Take 2 at browser_sync::ExtensionsActivityMonitor.... (Closed)

Created:
11 years, 1 month ago by tim (not reviewing)

Modified:
9 years, 6 months ago

Reviewers:
ncarter (slow)

CC:
chromium-reviews_googlegroups.com, ben+cc_chromium.org, Erik does not do reviews, idana, Aaron Boodman, pam+watch_chromium.org, Paweł Hajdan Jr.

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Take 2 at browser_sync::ExtensionsActivityMonitor. Original: http://codereview.chromium.org/325001/show TEST=ExtensionsActivityMonitorTest Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30313

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Patch Set 6 : '' #

Patch Set 7 : '' #

Patch Set 8 : '' #

Patch Set 9 : '' #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+183 lines, -70 lines)			Patch
M	chrome/browser/extensions/extension_bookmarks_module.h	View	1 2 3 4 5 6 7 8	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/extension_bookmarks_module.cc	View	1 2 3 4 5 6 7 8	1 chunk	+8 lines, -1 line	0 comments	Download
M	chrome/browser/extensions/extension_function.h	View	1 2 3 4 5 6 7 8	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/sync/engine/build_commit_command.h	View	1 2 3 4 5 6 7 8	1 chunk	+2 lines, -0 lines	0 comments	Download
M	chrome/browser/sync/engine/build_commit_command.cc	View	1 2 3 4 5 6 7 8	2 chunks	+15 lines, -0 lines	0 comments	Download
M	chrome/browser/sync/engine/process_commit_response_command.h	View	1 2 3 4 5 6 7 8	3 chunks	+8 lines, -1 line	0 comments	Download
M	chrome/browser/sync/engine/process_commit_response_command.cc	View	1 2 3 4 5 6 7 8	1 chunk	+9 lines, -1 line	0 comments	Download
M	chrome/browser/sync/engine/syncer.h	View	1 2 3 4 5 6 7 8	2 chunks	+5 lines, -0 lines	0 comments	Download
M	chrome/browser/sync/engine/syncer.cc	View	1 2 3 4 5 6 7 8	4 chunks	+25 lines, -2 lines	0 comments	Download
M	chrome/browser/sync/engine/syncer_session.h	View	1 2 3 4 5 6 7 8	3 chunks	+12 lines, -0 lines	0 comments	Download
M	chrome/browser/sync/protocol/sync.proto	View	1 2 3 4 5 6 7 8	3 chunks	+18 lines, -3 lines	0 comments	Download
A +	chrome/browser/sync/util/extensions_activity_monitor.h	View	1	2 chunks	+3 lines, -6 lines	0 comments	Download
A +	chrome/browser/sync/util/extensions_activity_monitor.cc	View	2 3 4	3 chunks	+20 lines, -14 lines	0 comments	Download
A +	chrome/browser/sync/util/extensions_activity_monitor_unittest.cc	View	1 2 3 4 5 6 7	13 chunks	+37 lines, -29 lines	0 comments	Download
M	chrome/chrome.gyp	View	1 2 3 4 5 6 7 8	5 chunks	+14 lines, -6 lines	0 comments	Download
M	chrome/common/notification_type.h	View	1 2 3 4 5 6 7 8	2 chunks	+5 lines, -5 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

ncarter (slow)

LGTM with one question (and of course, wait for the trybots). http://codereview.chromium.org/333041/diff/4001/5017 File chrome/browser/sync/profile_sync_service_unittest.cc (right): ...

11 years, 1 month ago (2009-10-27 19:38:20 UTC) #1

tim (not reviewing)

11 years, 1 month ago (2009-10-27 20:42:41 UTC) #2

Yeah, it's a little weird.  If you notice, message_loop_ wasn't used anywhere
either, but allocating it makes it such that MessageLoop::current() exists. 
With ui_thread_, this makes sure that referencing ChromeThread::UI from anywhere
will be talking about a valid thread, and the message loop will be
message_loop_, because it adds the entry in the static ChromeThread table for
'UI'. The comment in chrome_thread.h mentions this wonkiness, namely using a
"dummy" thread in unittests like this.

Expand Messages | Collapse Messages