Issue 333040: Revert (4 of 4) 30153 - Introduce browser_sync::ExtensionsActivityMonitor to ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 333040: Revert (4 of 4) 30153 - Introduce browser_sync::ExtensionsActivityMonitor to ... (Closed)

Created:
11 years, 1 month ago by tim (not reviewing)

Modified:
9 years, 6 months ago

Reviewers:
tim (not reviewing)

CC:
chromium-reviews_googlegroups.com, ncarter (slow), ben+cc_chromium.org, Erik does not do reviews, idana, Aaron Boodman, pam+watch_chromium.org, Paweł Hajdan Jr., tim (not reviewing)

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Revert (4 of 4) 30153 - Introduce browser_sync::ExtensionsActivityMonitor to collect extensions API usage for correlation to sync commit requests. Add ChromiumExtensionsActivity to sync.proto to allow passing this data to sync servers. BUG=25323 TEST=Added ExtensionsActivityMonitorTest. +Performing mutations on the bookmarks model via an extension should result in ChromiumExtensionsActivity for each such extension showing up in CommitMessages. Review URL: http://codereview.chromium.org/325001 TBR=tim@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30162

Patch Set 1 #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+18 lines, -521 lines)			Patch
M	chrome/browser/extensions/extension_bookmarks_module.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/extensions/extension_bookmarks_module.cc	View	1 chunk	+1 line, -8 lines	0 comments	Download
M	chrome/browser/extensions/extension_function.h	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/sync/engine/build_commit_command.h	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/browser/sync/engine/build_commit_command.cc	View	2 chunks	+0 lines, -15 lines	0 comments	Download
M	chrome/browser/sync/engine/process_commit_response_command.h	View	3 chunks	+1 line, -8 lines	0 comments	Download
M	chrome/browser/sync/engine/process_commit_response_command.cc	View	1 chunk	+1 line, -9 lines	0 comments	Download
M	chrome/browser/sync/engine/syncer.h	View	2 chunks	+0 lines, -5 lines	0 comments	Download
M	chrome/browser/sync/engine/syncer.cc	View	4 chunks	+2 lines, -28 lines	0 comments	Download
M	chrome/browser/sync/engine/syncer_session.h	View	3 chunks	+0 lines, -12 lines	0 comments	Download
M	chrome/browser/sync/protocol/sync.proto	View	3 chunks	+3 lines, -18 lines	0 comments	Download
D	chrome/browser/sync/util/extensions_activity_monitor.h	View	1 chunk	+0 lines, -74 lines	0 comments	Download
D	chrome/browser/sync/util/extensions_activity_monitor.cc	View	1 chunk	+0 lines, -93 lines	0 comments	Download
D	chrome/browser/sync/util/extensions_activity_monitor_unittest.cc	View	1 chunk	+0 lines, -234 lines	0 comments	Download
M	chrome/chrome.gyp	View	4 chunks	+3 lines, -8 lines	0 comments	Download
M	chrome/common/notification_type.h	View	2 chunks	+5 lines, -5 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages