Issue 333026: Mac: Make Cmd-[ and Cmd-] work properly again.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 333026: Mac: Make Cmd-[ and Cmd-] work properly again. (Closed)

Created:
11 years, 1 month ago by viettrungluu

Modified:
9 years, 6 months ago

Reviewers:
pink (ping after 24hrs), Nico

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Mac: Make Cmd-[ and Cmd-] work properly again. I had accidentally made them open new tabs. I added a |-commandDispatchUsingKeyModifiers:| method to the browser window controller and made the back/forward buttons send this selector instead (this is how Toolbar.xib was changed). [N.B.: As of this writing, Cmd+Shift-back/forwards is broken, but that's a separate, non-Mac-specific, issue.] BUG=25810 TEST=Make sure Cmd-[ and Cmd-] work as expected (not opening history items in new tabs). Make sure back and forward buttons work properly (including while holding down Cmd and Cmd+Shift). Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30059

Patch Set 1 #

Patch Set 2 : Changed to just use a different selector instead (per Nico's comment on IRC). #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+674 lines, -80 lines)			Patch
	M	chrome/app/nibs/Toolbar.xib	View	1	34 chunks	+659 lines, -66 lines	0 comments	Download
	M	chrome/browser/cocoa/browser_window_controller.mm	View	1	4 chunks	+15 lines, -14 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

viettrungluu

(See the changed description.) Also, Cmd+Shift-click on back/forwards button, but that's not Mac specific; I ...

11 years, 1 month ago (2009-10-26 16:45:19 UTC) #3

LGTM

Expand Messages | Collapse Messages