Issue 333021: Mac: Make middle-click tab closure cancellable.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 333021: Mac: Make middle-click tab closure cancellable. (Closed)

Created:
11 years, 2 months ago by viettrungluu

Modified:
9 years, 6 months ago

Reviewers:
pink (ping after 24hrs)

CC:
chromium-reviews_googlegroups.com

Visibility:
Public.

Description

Mac: Make middle-click tab closure cancellable. When middle-clicking a tab to close it, one should be able to move the mouse off the tab before releasing to cancel it. BUG=16019 TEST=Get a 3-button mouse. Make sure middle-clicking tabs to close them still works. Make sure moving the mouse off the tab before releasing the button cancels. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=30048

Patch Set 1 #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -1 line)			Patch
	M	chrome/browser/cocoa/tab_view.mm	View		1 chunk	+8 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages