Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(748)

Unified Diff: chrome/browser/cocoa/cocoa_test_helper.h

Issue 333017: Fixes up bookmark bubbles and the browser window so that they shut down corre... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/cocoa/cocoa_test_helper.h
===================================================================
--- chrome/browser/cocoa/cocoa_test_helper.h (revision 29973)
+++ chrome/browser/cocoa/cocoa_test_helper.h (working copy)
@@ -105,15 +105,15 @@
// displaying the view to make sure it won't crash, as well as removing it
// from a window. All tests that work with NSView subclasses and/or
// NSViewController subclasses should use it.
-#define TEST_VIEW(test_fixture, view_member_name) \
+#define TEST_VIEW(test_fixture, test_view) \
TEST_F(test_fixture, AddRemove##test_fixture) { \
- scoped_nsobject<NSView> view([view_member_name retain]); \
- EXPECT_EQ([test_window() contentView], [view_member_name superview]); \
- [view_member_name removeFromSuperview]; \
- EXPECT_FALSE([view_member_name superview]); \
+ scoped_nsobject<NSView> view([test_view retain]); \
+ EXPECT_EQ([test_window() contentView], [view superview]); \
+ [view removeFromSuperview]; \
+ EXPECT_FALSE([view superview]); \
} \
TEST_F(test_fixture, Display##test_fixture) { \
- [view_member_name display]; \
+ [test_view display]; \
}
// The classes below are deprecated and will be removed shortly. Do not write

Powered by Google App Engine
This is Rietveld 408576698