Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2791)

Unified Diff: chrome/browser/cocoa/bookmark_bubble_window_unittest.mm

Issue 333017: Fixes up bookmark bubbles and the browser window so that they shut down corre... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/cocoa/bookmark_bubble_window_unittest.mm
===================================================================
--- chrome/browser/cocoa/bookmark_bubble_window_unittest.mm (revision 29973)
+++ chrome/browser/cocoa/bookmark_bubble_window_unittest.mm (working copy)
@@ -5,24 +5,21 @@
#include "base/scoped_ptr.h"
#include "chrome/browser/cocoa/cocoa_test_helper.h"
#include "chrome/browser/cocoa/bookmark_bubble_window.h"
-#include "testing/gtest/include/gtest/gtest.h"
-#include "testing/platform_test.h"
-class BookmarkBubbleWindowTest : public PlatformTest {
- public:
- CocoaTestHelper cocoa_helper_;
+class BookmarkBubbleWindowTest : public CocoaTest {
};
TEST_F(BookmarkBubbleWindowTest, Basics) {
- scoped_nsobject<BookmarkBubbleWindow> window_;
- window_.reset([[BookmarkBubbleWindow alloc]
- initWithContentRect:NSMakeRect(0,0,10,10)]);
+ BookmarkBubbleWindow* window =
+ [[BookmarkBubbleWindow alloc] initWithContentRect:NSMakeRect(0, 0, 10, 10)
+ styleMask:NSBorderlessWindowMask
+ backing:NSBackingStoreBuffered
+ defer:NO];
+ EXPECT_TRUE([window canBecomeKeyWindow]);
+ EXPECT_FALSE([window canBecomeMainWindow]);
- EXPECT_TRUE([window_ canBecomeKeyWindow]);
- EXPECT_FALSE([window_ canBecomeMainWindow]);
-
- EXPECT_TRUE([window_ isExcludedFromWindowsMenu]);
- EXPECT_FALSE([window_ isReleasedWhenClosed]);
+ EXPECT_TRUE([window isExcludedFromWindowsMenu]);
+ [window close];
}

Powered by Google App Engine
This is Rietveld 408576698