Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Side by Side Diff: chrome/browser/cocoa/bookmark_bubble_view_unittest.mm

Issue 333017: Fixes up bookmark bubbles and the browser window so that they shut down corre... (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: '' Created 11 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2009 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2009 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #import <Cocoa/Cocoa.h>
6
7 #include "base/scoped_nsobject.h" 5 #include "base/scoped_nsobject.h"
8 #import "chrome/browser/cocoa/bookmark_bubble_view.h" 6 #import "chrome/browser/cocoa/bookmark_bubble_view.h"
9 #import "chrome/browser/cocoa/cocoa_test_helper.h" 7 #import "chrome/browser/cocoa/cocoa_test_helper.h"
10 #include "testing/gtest/include/gtest/gtest.h"
11 #include "testing/platform_test.h"
12 8
13 namespace { 9 namespace {
14 10
15 class BookmarkBubbleViewTest : public PlatformTest { 11 class BookmarkBubbleViewTest : public CocoaTest {
16 public: 12 public:
17 BookmarkBubbleViewTest() { 13 BookmarkBubbleViewTest() {
18 NSRect frame = NSMakeRect(0, 0, 100, 30); 14 NSRect frame = NSMakeRect(0, 0, 100, 30);
19 view_.reset([[BookmarkBubbleView alloc] initWithFrame:frame]); 15 scoped_nsobject<BookmarkBubbleView> view(
20 [cocoa_helper_.contentView() addSubview:view_.get()]; 16 [[BookmarkBubbleView alloc] initWithFrame:frame]);
17 view_ = view.get();
18 [[test_window() contentView] addSubview:view_];
21 } 19 }
22 20
23 CocoaTestHelper cocoa_helper_; // Inits Cocoa, creates window, etc... 21 BookmarkBubbleView* view_;
24 scoped_nsobject<BookmarkBubbleView> view_;
25 }; 22 };
26 23
27 // Test drawing and an add/remove from the view hierarchy to ensure 24 TEST_VIEW(BookmarkBubbleViewTest, view_);
28 // nothing leaks or crashes.
29 TEST_F(BookmarkBubbleViewTest, AddRemoveDisplay) {
30 [view_ display];
31 EXPECT_EQ(cocoa_helper_.contentView(), [view_ superview]);
32 [view_.get() removeFromSuperview];
33 EXPECT_FALSE([view_ superview]);
34 }
35 25
36 } // namespace 26 } // namespace
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698