Issue 333016: Adding mapping for third_party/makeself. This is to complete checkin of http...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 333016: Adding mapping for third_party/makeself. This is to complete checkin of http... (Closed)

Created:
11 years, 2 months ago by vangelis

Modified:
9 years, 7 months ago

Reviewers:
Antoine Labour, Vangelis Kokkevis, nmaxwell, piman

CC:
o3d-review_googlegroups.com, Tristan Schmelcher 2

Base URL:
svn://chrome-svn/chrome/trunk/src/o3d/

Visibility:
Public.

Description

Adding mapping for third_party/makeself. This is to complete checkin of http://codereview.appspot.com/132050

Patch Set 1 #

Patch Set 2 : '' #

Created: 11 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	DEPS	View	1	2 chunks	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

piman

On 2009/10/27 19:30:05, vangelis wrote: > Ping. Antoine, do you mind taking a look at ...

11 years, 1 month ago (2009-10-27 20:01:11 UTC) #2

nmaxwell

LGTM Looks like this has been submitted already, yes? Is it ok to close this ...

11 years, 1 month ago (2009-11-04 17:52:53 UTC) #3

Vangelis Kokkevis

11 years, 1 month ago (2009-11-04 18:04:24 UTC) #4

Yes, we seem to be all set now!  Thanks for submitting the package and sorry for
all the check-in madness.  I'm still not sure exactly why it didn't work for
you.

Expand Messages | Collapse Messages