Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5047)

Unified Diff: chrome/browser/extensions/extension_install_ui.h

Issue 333015: o Cleans up canonical extension_install_ui.cc to avoid #ifdefs when feasible.... (Closed) Base URL: http://src.chromium.org/svn/trunk/src/
Patch Set: '' Created 11 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/cocoa/extension_install_prompt.mm ('k') | chrome/browser/extensions/extension_install_ui.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_install_ui.h
===================================================================
--- chrome/browser/extensions/extension_install_ui.h (revision 30026)
+++ chrome/browser/extensions/extension_install_ui.h (working copy)
@@ -15,8 +15,10 @@
class ExtensionsService;
class MessageLoop;
class Profile;
+class InfoBarDelegate;
class SandboxedExtensionUnpacker;
class SkBitmap;
+class TabContents;
// Displays all the UI around extension installation.
class ExtensionInstallUI {
@@ -32,12 +34,13 @@
virtual void AbortInstall() = 0;
};
- // NOTE: The implementation of this is platform-specific.
+ // NOTE: The implementations of these functions are platform-specific.
static void ShowExtensionInstallPrompt(Profile* profile,
Delegate* delegate,
Extension* extension,
SkBitmap* install_icon,
const std::wstring& warning_text);
+ static void ShowExtensionInstallError(const std::string& error);
ExtensionInstallUI(Profile* profile);
@@ -60,8 +63,15 @@
void OnOverinstallAttempted(Extension* extension);
private:
+ // When a Theme is downloaded it is applied and an info bar is shown to give
+ // the user a choice to keep it or undo the installation.
void ShowThemeInfoBar(Extension* new_theme);
+ // Returns the delegate to control the browser's info bar. This is within its
+ // own function due to its platform-specific nature.
+ InfoBarDelegate* GetNewInfoBarDelegate(Extension* new_theme,
+ TabContents* tab_contents);
+
Profile* profile_;
MessageLoop* ui_loop_;
std::string previous_theme_id_; // Used to undo theme installation.
« no previous file with comments | « chrome/browser/cocoa/extension_install_prompt.mm ('k') | chrome/browser/extensions/extension_install_ui.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698