Issue 3330013: Fix keywords issue

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3330013: Fix keywords issue (Closed)

Created:
10 years, 3 months ago by sosa

Modified:
9 years, 6 months ago

Reviewers:
zbehan

CC:
chromium-os-reviews_chromium.org, Mandeep Singh Baines, anush, sosa

Base URL:
http://git.chromium.org/git/crosutils.git

Visibility:
Public.

Description

Fix keywords issue Change-Id: If89d91624d4e83d8f6923e873bfb57b95fa3b666 BUG= TEST=Ran with failing packages from buildbot.

Patch Set 1 #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -2 lines)			Patch
	M	cros_mark_as_stable.py	View		1 chunk	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

zbehan

10 years, 3 months ago (2010-09-08 22:01:29 UTC) #2

LGTM!

On Wed, Sep 8, 2010 at 2:50 PM, <sosa@chromium.org> wrote:

> Reviewers: zbehan,
>
> Description:
> Fix keywords issue
>
> Change-Id: If89d91624d4e83d8f6923e873bfb57b95fa3b666
>
> BUG=
> TEST=Ran with failing packages from buildbot.
>
> Please review this at http://codereview.chromium.org/3330013/show
>
> SVN Base: http://git.chromium.org/git/crosutils.git
>
> Affected files:
>  M cros_mark_as_stable.py
>
>
> Index: cros_mark_as_stable.py
> diff --git a/cros_mark_as_stable.py b/cros_mark_as_stable.py
> index
>
ea35fffa5b3a78faab11206cd84bd4ffc84cbfc2..1525fa7982f469f7fe576f0988e415dbfbbbadc8
> 100755
> --- a/cros_mark_as_stable.py
> +++ b/cros_mark_as_stable.py
> @@ -211,8 +211,9 @@ class _EBuild(object):
>   def _FindEBuildPath(cls, package):
>     """Static method that returns the full path of an ebuild."""
>     _Print('Looking for unstable ebuild for %s' % package)
> -    equery_cmd = 'equery-%s which %s 2> /dev/null' \
> -      % (gflags.FLAGS.board, package)
> +    equery_cmd = (
> +        'ACCEPT_KEYWORDS="x86 arm amd64" equery-%s which %s 2> /dev/null'
> +            % (gflags.FLAGS.board, package))
>     path = _SimpleRunCommand(equery_cmd)
>     if path:
>       _Print('Unstable ebuild found at %s' % path)
>
>
>

Expand Messages | Collapse Messages