Only run KDE browser fallback when necessary...

Only run KDE browser fallback when necessary

Otherwise, in some circumstances, read_kde_browser incorrectly prints the result twice.

BUG=33842
TEST=xdg-settings get default-web-browser should not output two files when kdeglobals contains a BrowserApplication[$*] entry

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=58316

[davidben, 2010-09-01 19:38:04]

Not sure if this is the right place to send this, now that xdg-settings is
upstreamed.

[Mike Mammarella, 2010-09-01 20:06:31]

On 2010/09/01 19:38:04, David Benjamin wrote:
> Not sure if this is the right place to send this, now that xdg-settings is
> upstreamed.

LGTM

It has been upstreamed, but we can make local changes and ship updated versions
in parallel with sending the patches upstream.

I've just recently updated the version in third_party myself, but I haven't yet
rolled DEPS to pick it up - I'm waiting for the M7 branch. So after you commit
this, send me the revision number and I'll update DEPS to it along with my other
change. (We'll be including a patched copy of xdg-mime, along with
xdg-settings.)

You can send the patch upstream to Fathi Boudra <fabo@freedesktop.org>, or if
you prefer, I can send it.

[davidben, 2010-09-02 04:13:32]

On 2010/09/01 20:06:31, Mike Mammarella wrote:
> I've just recently updated the version in third_party myself, but I haven't
yet
> rolled DEPS to pick it up - I'm waiting for the M7 branch. So after you commit
> this, send me the revision number and I'll update DEPS to it along with my
other
> change. (We'll be including a patched copy of xdg-mime, along with
> xdg-settings.)

Committed. It's r58316.

http://src.chromium.org/viewvc/chrome?view=rev&revision=58316


> You can send the patch upstream to Fathi Boudra <mailto:fabo@freedesktop.org>,
or if
> you prefer, I can send it.

Alright, I'll send it to him.

[fboudra, 2010-09-25 03:05:26]

On 2010/09/02 04:13:32, David Benjamin wrote:
> On 2010/09/01 20:06:31, Mike Mammarella wrote:
> > You can send the patch upstream to Fathi Boudra
<mailto:fabo@freedesktop.org>,
> or if
> > you prefer, I can send it.
> 
> Alright, I'll send it to him.

Merged. Thanks.