Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 3330001: Fix parsing of /**/--> on first line of input. (Closed)

Created:
10 years, 3 months ago by Lasse Reichstein
Modified:
9 years, 6 months ago
CC:
v8-dev
Visibility:
Public.

Description

Fix parsing of /**/--> on first line of input. BUG=53548 TEST= Committed: http://code.google.com/p/v8/source/detail?r=5400

Patch Set 1 #

Patch Set 2 : Added test-case. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+38 lines, -1 line) Patch
M src/scanner.cc View 3 chunks +5 lines, -1 line 0 comments Download
M test/cctest/test-parsing.cc View 2 chunks +33 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Lasse Reichstein
10 years, 3 months ago (2010-09-01 11:46:07 UTC) #1
Erik Corry
Mads is travelling. You should add a test, perhaps to the v8/test/messages directory.
10 years, 3 months ago (2010-09-01 12:16:04 UTC) #2
Lasse Reichstein
Added test. Feel free to review in Mads' place. :)
10 years, 3 months ago (2010-09-01 14:14:01 UTC) #3
Erik Corry
10 years, 3 months ago (2010-09-02 07:01:14 UTC) #4 
LGTM

Powered by Google App Engine
This is Rietveld 408576698