Issue 3329012: Change ICU_UTIL_DATA_IMPL on Linux to match the reality....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 3329012: Change ICU_UTIL_DATA_IMPL on Linux to match the reality.... (Closed)

Created:
10 years, 3 months ago by jungshik at Google

Modified:
9 years, 7 months ago

Reviewers:
agl, sgk

CC:
chromium-reviews, jshin+watch_chromium.org, brettw-cc_chromium.org, Evan Martin

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Change ICU_UTIL_DATA_IMPL on Linux to match the reality. We've bundled the ICU data file for 'ages' on Linux, but ICU_UTIL_DATA_IMPL on Linux is still set to ICU_UTIL_DATA_FILE. Apparently, this hasn't been noticed because u_setDataDirectory and udata_setFileAccess just set the global variable pointing to the data file location. This is not totally free because u_setDataDirectory does some locking/unlocking. BUG=NONE TEST=Builds go through on Linux and binaries (chrome, test, etc) run just fine. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=58725

Patch Set 1 #

Created: 10 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -4 lines)			Patch
	M	base/i18n/icu_util.cc	View		2 chunks	+2 lines, -4 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

lgtm++

Expand Messages | Collapse Messages