Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Unified Diff: trychange.py

Issue 3328002: Remove --webkit from trychange.py since it never really worked correctly. (Closed)
Patch Set: Created 10 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trychange.py
diff --git a/trychange.py b/trychange.py
index bed851ea0e2025087edcf7ddcc448675158eaeb0..d4eede1fab2da275ecf3c6e1c95500ffabebdf5f 100755
--- a/trychange.py
+++ b/trychange.py
@@ -547,25 +547,6 @@ def TryChange(argv,
"useful for gclient-style checkouts. Use @rev or "
"@branch or @branch1..branch2 to specify the "
"revision/branch to diff against.")
- # Mostly chromium-specific
- try:
- def WebKitRevision(options, opt, value, parser):
- if not hasattr(options, 'sub_rep'):
- options.sub_rep = []
- if parser.rargs and not parser.rargs[0].startswith('-'):
- options.sub_rep.append('third_party/WebKit@%s' % parser.rargs.pop(0))
- else:
- options.sub_rep.append('third_party/WebKit')
-
- group.add_option("-W", "--webkit", action="callback",
- callback=WebKitRevision,
- metavar="BRANCH",
- help="Shorthand for -s third_party/WebKit@BRANCH. "
- "BRANCH is optional and is the branch the current "
- "checkout will be diff'ed against.")
- except optparse.OptionError:
- # append_const is not supported on 2.4. Too bad.
- pass
group.add_option("--no_gclient", action="store_true",
help="Disable automatic search for gclient checkout.")
group.add_option("-E", "--exclude", action="append",
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698